Add support for Model Context Protocol#91
Merged
Merged
Conversation
tortmayr
requested changes
May 11, 2026
| applicationId: ApplicationIdProvider.get(), | ||
| protocolVersion: GLSPClient.protocolVersion | ||
| protocolVersion: GLSPClient.protocolVersion, | ||
| ...(this.options.mcpServer ? { mcpServer: this.options.mcpServer } : {}) |
Contributor
There was a problem hiding this comment.
Why not use
mcpServer: this.options.mcpServer ?? {} ?
Contributor
Author
There was a problem hiding this comment.
Because we do not want to set mcpServer if it is not configured. Just setting the property is the opt-in for us to start the MCP server with default configuration.
Bridges the GLSP-announced MCP server into the IDE's built-in MCP definition provider API, surfacing the URL in the IDE's MCP server list. MCP integration - Node-side provider registers the announced endpoint on startup and deregisters on extension dispose. - Plumbs an opt-in MCP server configuration through the connector base classes. - Raises the minimum supported IDE version to the release shipping the MCP definition provider API. Adopters - Enable MCP by setting the configuration on the connector. - The workflow example demonstrates the end-to-end wiring with a transient connect notification and a copy-URL action. Misc - Webview content-security policy allows blob URLs as image sources, enabling client-side PNG export inside the webview. - Adapts the webview shutdown bridge to the widened asynchronous shutdown contract. Part of eclipse-glsp/glsp#1546
martin-fleck-at
force-pushed
the
issues/1546
branch
from
95dfe2a to
222656d
Compare
Contributor
Author
|
@tortmayr Pushed an update to the latest server, everything should work now, please test :-) |
tortmayr
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Bridges the GLSP-announced MCP server into the IDE's built-in MCP definition provider API, surfacing the URL in the IDE's MCP server list.
MCP integration
Adopters
Misc
Part of eclipse-glsp/glsp#1546
Requires eclipse-glsp/glsp-client#456 and eclipse-glsp/glsp-server-node#120
How to test
Follow-ups
Changelog